doc: recommend node-stress-single-test for flaky tests#64223
Conversation
|
Review requested:
|
Add guidance to the collaborator guide and onboarding docs recommending node-stress-single-test when fixing flaky tests, so contributors verify stability under repeated runs. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
trivikr
force-pushed
the
doc-node-stress-single-test
branch
from
f20aca5 to
ef9208e
Compare
trivikr
added
the
flaky-test
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
added
the
author ready
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
Suggest adding the hyperlink in, but approving regardless 👍🏻
| * If you are interested in helping out with CI reliability, check out the | ||
| [reliability repository][] and [guide on how to deal with CI flakes][]. | ||
| [reliability repository][] and [guide on how to deal with CI flakes][]. When | ||
| fixing a flaky test, it is recommended to run [`node-stress-single-test`][] |
There was a problem hiding this comment.
| fixing a flaky test, it is recommended to run [`node-stress-single-test`][] | |
| fixing a flaky test, it is recommended to run [`node-stress-single-test`][https://ci.nodejs.org/job/node-stress-single-test] |
There was a problem hiding this comment.
Mentioning the hyperlink in the bottom improves the source code readability, right?
It's done twice on line 289 for example.
[reliability repository][] and [guide on how to deal with CI flakes][].
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
|
It is not very useful if the flaky test is in |
The |
|
How about something like "When fixing a flaky test in |
trivikr
removed
the
author ready
7 participants
Recommend
node-stress-single-testin the collaborator guide and onboardingdocs for validating fixes to flaky tests.
Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1782716150521499